[PATCH] D78413: Require "target datalayout" to be at the beginning of an IR file.

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

LGTM.

I didn't know we had weird header infos in the middle of test files.



================
Comment at: llvm/lib/AsmParser/LLParser.cpp:303-313
+  while (true) {
+    if (Lex.getKind() == lltok::kw_target) {
+      if (ParseTargetDefinition())
+        return true;
+    } else if (Lex.getKind() == lltok::kw_source_filename) {
+      if (ParseSourceFileName())
+        return true;
----------------
[suggestion]

```
  while (true) {
    if (Lex.getKind() == lltok::kw_target) {
      if (ParseTargetDefinition())
        return true;
      continue;
    }

    if (Lex.getKind() == lltok::kw_source_filename) {
      if (ParseSourceFileName())
        return true;
      continue;
    } 
    
    return false;
  }
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78413/new/

https://reviews.llvm.org/D78413