[PATCH] D78243: New pass to make internal linkage symbol names unique

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

You may need an `opt -passes='...'` test for the new pass manager and implement the new pass.

We are using `-fexperimental-new-pass-manager` heavily.



================
Comment at: llvm/include/llvm/Transforms/Utils/UniqueInternalLinkageNames.h:27
+public:
+  UniqueInternalLinkageNamesPass() = default;
+  PreservedAnalyses run(Module &M, ModuleAnalysisManager &AM);
----------------
The defaulted default constructor can be deleted.


================
Comment at: llvm/lib/Transforms/Utils/UniqueInternalLinkageNames.cpp:30
+  llvm::MD5::stringifyResult(R, Str);
+  std::string ModuleNameHash = ("." + Str).str();
+  bool Changed = false;
----------------
(Twine('.') + Twine(Str))


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78243/new/

https://reviews.llvm.org/D78243