[PATCH] D78407: [libunwind] Fix ARM EHABI unwinding instruction calculation

Ryan Prichard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 17 17:31:26 PDT 2020


rprichard added a comment.

I think libunwind is already correct. It's doing:

  vsp -= (xxxxxx << 2) + 4

The addition has higher precedence than the compound assignment, so it's equivalent to:

  vsp = vsp - ((xxxxxx << 2) + 4)

i.e.

  vsp = vsp - (xxxxxx << 2) - 4


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78407/new/

https://reviews.llvm.org/D78407





More information about the llvm-commits mailing list