[PATCH] D78395: [llvm][NFC][CallSite] Remove CallSite from Evaluator.
Mircea Trofin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 17 16:34:39 PDT 2020
mtrofin marked an inline comment as done.
mtrofin added inline comments.
================
Comment at: llvm/lib/Transforms/Utils/Evaluator.cpp:282
-bool Evaluator::getFormalParams(CallSite &CS, Function *F,
+bool Evaluator::getFormalParams(CallBase *CB, Function *F,
SmallVector<Constant *, 8> &Formals) {
----------------
dblaikie wrote:
> This one's less clear - up to you if you want to look closer to figure out if it could be reference. (the only issue is whether callers actually need to pass null CB when they pass null F - if they still pass non-null CB when F is null, then CB might as well be a reference)
Both members are only used internally, we could make them private.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78395/new/
https://reviews.llvm.org/D78395
More information about the llvm-commits
mailing list