[PATCH] D78179: [Darwin] Fix symbolization for recent simulator runtimes.

[Dan Liew via Phabricator via llvm-commits]

delcypher marked 3 inline comments as done.
delcypher added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_mac.cpp:101
+                                     K_ATOS_ENV_VAR "=%s", pid_str_);
+      CHECK_GE(count, sizeof(K_ATOS_ENV_VAR) + 1);
+      // Document our assumption but without calling `getenv()` in normal
----------------
yln wrote:
> We could assert "equal" on the exact count `sizeof(K_ATOS_ENV_VAR) + 1 + internal_strlen(pid_str_)`
Done. You don't need the `+1` though .


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_mac.cpp:135
 
+#undef K_ATOS_ENV_VAR
+
----------------
yln wrote:
> Is this considered good hygiene?  Personally, I would drop it, but I am fine either way.
I consider it good hygiene for the macro to be defined for only as long as its needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78179/new/

https://reviews.llvm.org/D78179