[PATCH] D78375: AMDGPU: Remove custom node for RSQ_LEGACY

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 17 12:58:42 PDT 2020


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp:4714
+      if (SNaN)
+        return true;
+
----------------
rampitec wrote:
> Isn't sNaN a NaN?
The SNaN parameter to isKnownNeverNaNForTargetNode makes this isKnownNeverSignallingNaN. Since these are canonicalizing operations, they quiet and therefore never return an snan


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78375/new/

https://reviews.llvm.org/D78375





More information about the llvm-commits mailing list