[PATCH] D78383: [LVI] Use Optional instead of out parameter (NFC)

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: lib/Analysis/LazyValueInfo.cpp:839
+    return None;
+  ValueLatticeElement TrueVal = *OptTrueVal;
 
----------------
nikic wrote:
> nikic wrote:
> > My C++ foo is weak... would the proper way to write this without copying the lattice value be `TrueValue = *std::move(OptTrueVal)`?
> Hm, it looks like moving an Optional moves the value (rather than making the Optional empty). As ValueLatticeElement does not specify a move constructor, I guess that means it would end up being copied, so that probably doesn't make sense.
Can this just be `ValueLatticeElement &TrueVal`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78383/new/

https://reviews.llvm.org/D78383