[PATCH] D78145: [ValueLattice] Steal bits from Tag to track range extensions (NFC).

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 17 12:16:17 PDT 2020



> On Apr 17, 2020, at 17:42, Florian Hahn via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> fhahn marked an inline comment as done.
> fhahn added inline comments.
> 
> 
> ================
> Comment at: llvm/include/llvm/Analysis/ValueLattice.h:78
> 
> -  ValueLatticeElementTy Tag;
> +  ValueLatticeElementTy Tag : 6;
> +  /// Number of times a constant range has been extended with widening enabled.
> ----------------
> nikic wrote:
>> Why 6? I would expect either 3 here (because that's enough to represent the states) or 8 (an ISA friendly number).
> The main intention was to leave enough space for plenty of further extension while keeping plenty of other bits for other stuff. But it's probably worth to extend it to 8. I'll do that as a follow up commit.
> 

I’ll push a commit tomorrow.


More information about the llvm-commits mailing list