[PATCH] D78340: [Flang] fix dependency issues after D78215

David Truby via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 17 08:37:47 PDT 2020


DavidTruby added a comment.

I can reproduce @clementval's issue, but only when using `make` and not when using `ninja` which seems very odd to me. I do also expect the circular dependency to be needed at the moment so I think this patch is correct on that point. Fixing the circular dependency needs work outside the build system as there is actually a circular dependency in the code.
I'm inclined to say that given we broke something that used to work, we should merge this patch to fix that even if it breaks things that the last patch fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78340/new/

https://reviews.llvm.org/D78340





More information about the llvm-commits mailing list