[PATCH] D78340: [Flang] fix dependency issues after D78215

Fri Apr 17 08:05:29 PDT 2020

clementval marked an inline comment as done.
clementval added inline comments.

================
Comment at: flang/lib/Optimizer/Dialect/CMakeLists.txt:9
   FIROpsIncGen
+  FIRSupport

----------------
stephenneuendorffer wrote:
> clementval wrote:
> > ChinouneMehdi wrote:
> > > clementval wrote:
> > > > ChinouneMehdi wrote:
> > > > > FortranSupport is already declared as a dependency, why!
> > > > Compile time dependency and link time dependency are not the same. 
> > > Your problem was occurring with FIRSupport, so why introducing this dependency to FIRDialect?
> > Obviously, I didn't attached the 5-6 errors occurring. The change I posted in this patch are needed at least on the system I used to compile Flang (Summit node). 
> This should not be necessary since FIRSupport is a library dependency.
Since FIRDialect need also the file generated by Tablegen, this dependency solves it. Of course, we can add the dialect dependency here as well.  

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78340/new/

https://reviews.llvm.org/D78340