[PATCH] D78208: [DebugInfo] Report the format of the DWARF64 sections.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 17 08:05:27 PDT 2020


jhenderson added a comment.

> I thought about that, but the changes in the output would make it incompatible with lots of existing tests and, probably, might affect some external tools.

I think the effect on external tools is a non-issue, not in the sense that it wouldn't be a problem (it could be), but rather in the sense that as it stands, this change introduces an issue anyway, since the external tools might suddenly start seeing this new format, or worse, might start seeing it at a future point when something causes a file to start using DWARF64.

Everything else in this change looks fine to me. I also don't feel strongly about the above point - nothing actually produces DWARF64 currently that I know of, so maybe it's not worth worrying about too much either way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78208/new/

https://reviews.llvm.org/D78208





More information about the llvm-commits mailing list