[PATCH] D76596: Backport 4878aa36d4a [ValueLattice] Add new state for undef constants.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 2 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/include/llvm/Analysis/ValueLattice.h:37
+    /// assuming all uses of the result will be replaced.
+    undef,
 
----------------
tstellar wrote:
> I'm fairly certain this is an API and ABI breaking change, I'm fixing up the abi check job on GitHub actions to try to confirm this.
I moved the new value to the end. Maybe that helps for existing clients?


================
Comment at: llvm/include/llvm/Analysis/ValueLattice.h:142
 
-  bool isUndefined() const { return Tag == undefined; }
   bool isConstant() const { return Tag == constant; }
----------------
tstellar wrote:
> Removing this is an ABI breaking change, so the patch would need to be modified to keep this in.
I kept isUndefined, which should just be isUnknownOrUndef.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76596/new/

https://reviews.llvm.org/D76596