[PATCH] D78340: [Flang] fix dependency issues after D78215

[Valentin Clement via Phabricator via llvm-commits]

clementval marked an inline comment as done.
clementval added a subscriber: ChinouneMehdi.
clementval added a comment.

In D78340#1988766 <https://reviews.llvm.org/D78340#1988766>, @ChinouneMehdi wrote:

> In D78340#1988739 <https://reviews.llvm.org/D78340#1988739>, @clementval wrote:
>
> > In D78340#1988692 <https://reviews.llvm.org/D78340#1988692>, @ChinouneMehdi wrote:
> >
> > > I think this change will fix your problem: D78354 <https://reviews.llvm.org/D78354>
> > >  Just a question: Have you try to investigate where the problem is before making these changes?
> >
> >
> > Of course I did. Do you think I just randomly try something to fix it. I find your comment quite offensive, please try to think before asking this kind of question. Your patch for sure doesn't fix my problem with FIRSemantics.
>
>
> Sorry, I didn't mean no offense.


All good



================
Comment at: flang/lib/Optimizer/Support/CMakeLists.txt:6-7
 
+  DEPENDS
+  ${dialect_libs}
   LINK_LIBS
----------------
ChinouneMehdi wrote:
> clementval wrote:
> > ChinouneMehdi wrote:
> > > Same here!
> > This is needed as this is a compile time dependency as well. Before your patch everything was compiling fine. But not after it. Those change are fixing the problem your introduced on the system I use at least. 
> The problem was because of a file that wasn't generated before building FIRSupport, so to fix the problem it suffices to introduce a dependency on it ( implicitly or explicitly).
I agree with this ... those file are generated by Tablegen so of course we can put those dependency here but it is not cleaner to depends on the dialects since they are ultimately generating those files and these are the dependencies one would see when looking at the header in FIRSupport and FIRDialect?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78340/new/

https://reviews.llvm.org/D78340