[PATCH] D78318: [GlobalISel][InlineAsm] Add support for basic output operand constraints

[Konstantin Schwarz via Phabricator via llvm-commits]

kschwarz marked 6 inline comments as done.
kschwarz added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/InlineAsmLowering.cpp:119-120
+
+  // Remember the type of the register for later
+  OpInfo.RegType = *TRI.legalclasstypes_begin(*RC);
+
----------------
arsenm wrote:
> Picking types from classes is usually problematic for me. Do we really need this type, and if so, is it feasible to use LLT instead?
Nope, I actually had a FIXME to remove it. We should only need the register size, and this we can always recompute.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78318/new/

https://reviews.llvm.org/D78318