[llvm] 818126a - [x86] rename variables for types for readability; NFC
Sanjay Patel via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 17 05:43:23 PDT 2020
Author: Sanjay Patel
Date: 2020-04-17T08:41:18-04:00
New Revision: 818126ae973e3e790185c808ee2f5b025847f3d4
URL: https://github.com/llvm/llvm-project/commit/818126ae973e3e790185c808ee2f5b025847f3d4
DIFF: https://github.com/llvm/llvm-project/commit/818126ae973e3e790185c808ee2f5b025847f3d4.diff
LOG: [x86] rename variables for types for readability; NFC
This gets harder to follow if we allow changing types/sizes
between source, dest, and intermediate value.
Added:
Modified:
llvm/lib/Target/X86/X86ISelLowering.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index 918cb154e219..fcdfd85d42ec 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -19183,9 +19183,9 @@ static SDValue lowerFPToIntToFP(SDValue CastToFP, SelectionDAG &DAG,
// See if we have a 128-bit vector cast op for this type of cast.
unsigned NumEltsInXMM = 128 / VT.getScalarSizeInBits();
- MVT Vec128VT = MVT::getVectorVT(VT, NumEltsInXMM);
- MVT Int128VT = MVT::getVectorVT(IntVT, NumEltsInXMM);
- if (!useVectorCast(CastToFP.getOpcode(), Int128VT, Vec128VT, Subtarget))
+ MVT VecFPVT = MVT::getVectorVT(VT, NumEltsInXMM);
+ MVT VecIntVT = MVT::getVectorVT(IntVT, NumEltsInXMM);
+ if (!useVectorCast(CastToFP.getOpcode(), VecIntVT, VecFPVT, Subtarget))
return SDValue();
// sint_to_fp (fp_to_sint X) --> extelt (sint_to_fp (fp_to_sint (s2v X))), 0
@@ -19196,9 +19196,9 @@ static SDValue lowerFPToIntToFP(SDValue CastToFP, SelectionDAG &DAG,
// penalties) with cast ops.
SDLoc DL(CastToFP);
SDValue ZeroIdx = DAG.getIntPtrConstant(0, DL);
- SDValue VecX = DAG.getNode(ISD::SCALAR_TO_VECTOR, DL, Vec128VT, X);
- SDValue VCastToInt = DAG.getNode(ISD::FP_TO_SINT, DL, Int128VT, VecX);
- SDValue VCastToFP = DAG.getNode(ISD::SINT_TO_FP, DL, Vec128VT, VCastToInt);
+ SDValue VecX = DAG.getNode(ISD::SCALAR_TO_VECTOR, DL, VecFPVT, X);
+ SDValue VCastToInt = DAG.getNode(ISD::FP_TO_SINT, DL, VecIntVT, VecX);
+ SDValue VCastToFP = DAG.getNode(ISD::SINT_TO_FP, DL, VecFPVT, VCastToInt);
return DAG.getNode(ISD::EXTRACT_VECTOR_ELT, DL, VT, VCastToFP, ZeroIdx);
}
More information about the llvm-commits
mailing list