[PATCH] D78201: [Target][ARM] Replace outdated getARMVPTBlockMask function

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: llvm/lib/Target/ARM/Thumb2InstrInfo.cpp:742
+void llvm::recomputeVPTBlockMask(MachineBasicBlock::instr_iterator Iter,
+                                 MachineBasicBlock::instr_iterator End) {
+  assert(
----------------
I think it would be cleaner just to pass a MachineInstr, which you can then derive these iterators.


================
Comment at: llvm/lib/Target/ARM/Thumb2InstrInfo.cpp:744
+  assert(
+      (Iter->getOpcode() == ARM::MVE_VPST || isVPTOpcode(Iter->getOpcode())) &&
+      "Not a VPST or VPT Instruction!");
----------------
VPST is covered by the isVPTOpcode helper.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78201/new/

https://reviews.llvm.org/D78201