[PATCH] D78102: [MC][DWARF] Corrected handling of is_stmt flag in .loc directives

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 17 05:22:13 PDT 2020


probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.

I suggest using past tense in the description, because commentary should describe the code as it is (after the patch).
Ex: llvm assembler handled ... it forced ... is_stmt was specified ...

LGTM aside from that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78102/new/

https://reviews.llvm.org/D78102





More information about the llvm-commits mailing list