[PATCH] D78340: [Flang] fix dependenvy issues after D78215

[مهدي شينون (Mehdi Chinoune) via Phabricator via llvm-commits]

ChinouneMehdi added inline comments.


================
Comment at: flang/lib/Evaluate/CMakeLists.txt:32
   FortranDecimal
+  FortranSemantics
   FortranParser
----------------
You are reintroducing a cycle-dependency between FortranEvaluate and FortranSemantics, and in addition FortranEvaluate doesn't call any function from FortranSemantics.


================
Comment at: flang/lib/Optimizer/Dialect/CMakeLists.txt:9
   FIROpsIncGen
+  FIRSupport
 
----------------
FortranSupport is already declared as a dependency, why!


================
Comment at: flang/lib/Optimizer/Support/CMakeLists.txt:6-7
 
+  DEPENDS
+  ${dialect_libs}
   LINK_LIBS
----------------
Same here!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78340/new/

https://reviews.llvm.org/D78340