[PATCH] D78255: [AMDGPU] copyPhysReg() for 16 bit SGPR subregs

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 16 13:56:40 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:714
+    if (IsSGPRSrc && !ST.hasSDWAScalar()) {
+      assert(DstLow && SrcLow && "Cannot use hi16 subreg on VI!");
+      BuildMI(MBB, MI, DL, get(AMDGPU::V_MOV_B32_e32), DestReg)
----------------
Maybe should be report_fatal_error since you could write unsatisfiable MIR, and also a test that hits it


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78255/new/

https://reviews.llvm.org/D78255





More information about the llvm-commits mailing list