[PATCH] D78203: [VP,Integer,#2] ExpandVectorPredication pass

Simon Moll via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 17 01:35:18 PDT 2020


simoll added inline comments.


================
Comment at: llvm/lib/CodeGen/ExpandVectorPredication.cpp:197-198
+    // Division operators need a safe divisor on masked-off lanes (1.0)
+    case Instruction::FDiv:
+    case Instruction::FRem:
+    case Instruction::UDiv:
----------------
arsenm wrote:
> Shouldn't be true for FP divisions
Yep. At least not before we have vector-predicated, constrained fdiv.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78203/new/

https://reviews.llvm.org/D78203





More information about the llvm-commits mailing list