[PATCH] D78309: [LLVM] Remove wrong DBG_VALUE instruction with one operand in AArch64 test case

Daniel Kiss via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 17 01:35:18 PDT 2020


danielkiss added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/branch-target-enforcement.mir:343
     ; CHECK-NOT: HINT
-    ; CHECK: DBG_VALUE
     ; CHECK: frame-setup PACIASP
----------------
efriedma wrote:
> I think this is breaking the point of the test: it's specifically supposed to be checking that DBG_VALUE instructions don't confuse the transform.  (So the test doesn't really care what the DBG_VALUE is, but it does care that one exists.)
> 
> Probably not too important, but still.
For background please take a look: D74492
I prefer to fix the DBG_VALUE instead of removing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78309/new/

https://reviews.llvm.org/D78309





More information about the llvm-commits mailing list