[PATCH] D78208: [DebugInfo] Report the format of the DWARF64 sections.

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 16 22:10:31 PDT 2020


ikudrin added a comment.

In D78208#1986988 <https://reviews.llvm.org/D78208#1986988>, @dblaikie wrote:

> Perhaps it'd be too subtle, but another direction we could go would be to print the length as 32 or 64 bits depending on the encoding and using that to signal 64/32, without an explicit field. It'd match the input format (where the size of the length indicates whether it's 32 or 64).


The idea is interesting, but the output would not be that explicit, right? And all the leading zeros would look so tedious to my taste. Moreover, it would require changes in more places in the code to make the output uniform.

Another possibility is the way used in `readelf`:

  Compilation Unit @ offset 0x0:
   Length:        0x430 (32-bit)

or

  Length:        0x430 (64-bit)

However, it looks like it does that only for `.debug_info` sections; for other debug tables it just prints the value of the length. And for some sections, like `.debug_frame`, that approach cannot be used without breaking the output format.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78208/new/

https://reviews.llvm.org/D78208





More information about the llvm-commits mailing list