[PATCH] D78190: Add Bfloat IR type

[Ties Stuij via Phabricator via llvm-commits]

stuij marked an inline comment as done.
stuij added inline comments.


================
Comment at: llvm/include/llvm/IR/Constants.h:790
+  static Constant *getFP(Type *ElementType, ArrayRef<uint64_t> Elts);
 
   /// Return a ConstantVector with the specified constant in each element.
----------------
jdoerfert wrote:
> Drive by: The documentation of these functions need to be changed and it needs to be clarified what would happen if you pass `double` to the `uint16_y` version.
Thanks. I changed the documentation and added type asserts to guard against passing unfit types.


================
Comment at: llvm/test/Assembler/bfloat-constprop.ll:1
+; RUN: opt < %s -O3 -S | FileCheck %s
+; RUN: verify-uselistorder %s
----------------
arsenm wrote:
> This test is doing way too much. You can reduce the to just ret fadd K0, K1
Fair to all the testcase comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78190/new/

https://reviews.llvm.org/D78190