[PATCH] D77893: [lld] Merge Mach-O input sections

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/OutputSection.cpp:34
+
+  this->hidden |= input->isHidden();
+  this->inputs.push_back(input);
----------------
int3 wrote:
> smeenai wrote:
> > Can you add a TODO for figuring out how we should handle input sections with conflicting hidden-ness?
> Personally I don't think we should support hidden InputSections until we find a use case (I'm not aware of one so far)
I.e. I think the synthetic sections could become OutputSections. So the only InputSections would actually be from real inputs, which will never be hidden


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77893/new/

https://reviews.llvm.org/D77893