[PATCH] D77353: [WebAssembly] Add DW_OP_WASM_location_int

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 16 15:37:42 PDT 2020


dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.

LGTM with one nit



================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrInfo.cpp:238
   static const std::pair<int, const char *> TargetIndices[] = {
-      {WebAssembly::TI_LOCAL_START, "wasm-local-start"},
-      {WebAssembly::TI_GLOBAL_START, "wasm-global-start"},
-      {WebAssembly::TI_OPERAND_STACK_START, "wasm-operator-stack-start"}};
+      {WebAssembly::TI_LOCAL, "wasm-local-start"},
+      {WebAssembly::TI_GLOBAL_FIXED, "wasm-global-start"},
----------------
I'm not exactly sure what these strings are for, but they should probably be changed to reflect the new naming of the enums?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77353/new/

https://reviews.llvm.org/D77353





More information about the llvm-commits mailing list