[PATCH] D76294: [PowerPC][Future] Add initial support for PC Relative addressing to get block address

[Victor Huang via Phabricator via llvm-commits]

NeHuang updated this revision to Diff 258163.
NeHuang added a comment.

Address review comment


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76294/new/

https://reviews.llvm.org/D76294

Files:
  llvm/lib/Target/PowerPC/PPCISelLowering.cpp
  llvm/test/CodeGen/PowerPC/pcrel-block-address.ll


Index: llvm/test/CodeGen/PowerPC/pcrel-block-address.ll
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/PowerPC/pcrel-block-address.ll
@@ -0,0 +1,19 @@
+; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-unknown-linux-gnu \
+; RUN:   -mcpu=future -ppc-asm-full-reg-names < %s | FileCheck %s
+
+; The test checks for getting block address using PC Relative addressing.
+
+define dso_local void @blockaddress() {
+; CHECK-LABEL: blockaddress:
+; CHECK:       # %bb.0: # %entry
+; CHECK:       paddi r3, 0, .Ltmp0 at PCREL, 1
+; CHECK:       bl helper at notoc
+entry:
+  tail call void @helper(i8* blockaddress(@blockaddress, %label))
+  br label %label
+
+label:                                            ; preds = %entry
+  ret void
+}
+
+declare void @helper(i8*)
Index: llvm/lib/Target/PowerPC/PPCISelLowering.cpp
===================================================================
--- llvm/lib/Target/PowerPC/PPCISelLowering.cpp
+++ llvm/lib/Target/PowerPC/PPCISelLowering.cpp
@@ -2539,6 +2539,11 @@
   return true;
 }
 
+template <typename Ty> static bool isValidPCRelNode(SDValue N) {
+  Ty *PCRelCand = dyn_cast<Ty>(N);
+  return PCRelCand && (PCRelCand->getTargetFlags() & PPCII::MO_PCREL_FLAG);
+}
+
 /// Returns true if this address is a PC Relative address.
 /// PC Relative addresses are marked with the flag PPCII::MO_PCREL_FLAG.
 bool PPCTargetLowering::SelectAddressPCRel(SDValue N, SDValue &Base) const {
@@ -2548,18 +2553,14 @@
     return true;
   }
 
-  ConstantPoolSDNode *ConstPoolNode =
-      dyn_cast<ConstantPoolSDNode>(N.getNode());
-  bool ConstPool = ConstPoolNode &&
-                   ConstPoolNode->getTargetFlags() | PPCII::MO_PCREL_FLAG;
-  GlobalAddressSDNode *GSDN = dyn_cast<GlobalAddressSDNode>(N.getNode());
-  bool Global = GSDN && GSDN->getTargetFlags() | PPCII::MO_PCREL_FLAG;
-  JumpTableSDNode *JT = dyn_cast<JumpTableSDNode>(N.getNode());
-  bool JumpTable = JT && JT->getTargetFlags() | PPCII::MO_PCREL_FLAG;
-  if (ConstPool || Global || JumpTable) {
+  if (isValidPCRelNode<ConstantPoolSDNode>(N) ||
+      isValidPCRelNode<GlobalAddressSDNode>(N) ||
+      isValidPCRelNode<JumpTableSDNode>(N) ||
+      isValidPCRelNode<BlockAddressSDNode>(N)) {
     Base = N;
     return true;
   }
+
   return false;
 }
 
@@ -2891,6 +2892,16 @@
   BlockAddressSDNode *BASDN = cast<BlockAddressSDNode>(Op);
   const BlockAddress *BA = BASDN->getBlockAddress();
 
+  // isUsingPCRelativeCalls() returns true when PCRelative is enabled
+  if (Subtarget.isUsingPCRelativeCalls()) {
+    SDLoc DL(BASDN);
+    EVT Ty = getPointerTy(DAG.getDataLayout());
+    SDValue GA = DAG.getTargetBlockAddress(BA, Ty, BASDN->getOffset(),
+                                           PPCII::MO_PCREL_FLAG);
+    SDValue MatAddr = DAG.getNode(PPCISD::MAT_PCREL_ADDR, DL, Ty, GA);
+    return MatAddr;
+  }
+
   // 64-bit SVR4 ABI and AIX ABI code are always position-independent.
   // The actual BlockAddress is stored in the TOC.
   if (Subtarget.is64BitELFABI() || Subtarget.isAIXABI()) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76294.258163.patch
Type: text/x-patch
Size: 3061 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200416/84c78641/attachment.bin>