[PATCH] D75931: [PowerPC][Future] Add initial support for PC Relative addressing to get jump table base address
Victor Huang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 16 13:56:44 PDT 2020
NeHuang updated this revision to Diff 258161.
NeHuang added a comment.
Addressed review comment.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75931/new/
https://reviews.llvm.org/D75931
Files:
llvm/lib/Target/PowerPC/PPCISelLowering.cpp
llvm/test/CodeGen/PowerPC/pcrel-jump-table.ll
Index: llvm/test/CodeGen/PowerPC/pcrel-jump-table.ll
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/PowerPC/pcrel-jump-table.ll
@@ -0,0 +1,57 @@
+; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-unknown-linux-gnu \
+; RUN: -mcpu=future -ppc-asm-full-reg-names < %s | FileCheck %s \
+; RUN: --check-prefix=CHECK-R
+; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-unknown-linux-gnu \
+; RUN: -mcpu=future -ppc-use-absolute-jumptables \
+; RUN: -ppc-asm-full-reg-names < %s | FileCheck %s \
+; RUN: --check-prefix=CHECK-A
+
+; This test checks for getting relative and absolute jump table base address
+; using PC Relative addressing.
+
+define dso_local signext i32 @jumptable(i32 signext %param) {
+; CHECK-R-LABEL: jumptable:
+; CHECK-R: # %bb.1: # %entry
+; CHECK-R-NEXT: rldic r4, r4
+; CHECK-R-NEXT: paddi r5, 0, .LJTI0_0 at PCREL, 1
+; CHECK-R-NEXT: lwax r4, r4, r5
+; CHECK-R-NEXT: add r4, r4, r5
+; CHECK-R-NEXT: mtctr r4
+; CHECK-R-NEXT: bctr
+; CHECK-A-LABEL: jumptable:
+; CHECK-A: # %bb.1: # %entry
+; CHECK-A-NEXT: rldic r4, r4
+; CHECK-A-NEXT: paddi r5, 0, .LJTI0_0 at PCREL, 1
+; CHECK-A-NEXT: ldx r4, r4, r5
+; CHECK-A-NEXT: mtctr r4
+; CHECK-A-NEXT: bctr
+
+entry:
+ switch i32 %param, label %sw.default [
+ i32 1, label %return
+ i32 2, label %sw.bb1
+ i32 3, label %sw.bb2
+ i32 4, label %sw.bb3
+ i32 20, label %sw.bb4
+ ]
+
+sw.bb1: ; preds = %entry
+ br label %return
+
+sw.bb2: ; preds = %entry
+ br label %return
+
+sw.bb3: ; preds = %entry
+ br label %return
+
+sw.bb4: ; preds = %entry
+ br label %return
+
+sw.default: ; preds = %entry
+ br label %return
+
+return: ; preds = %entry, %sw.default, %sw.bb4, %sw.bb3, %sw.bb2, %sw.bb1
+ %retval.0 = phi i32 [ -1, %sw.default ], [ 400, %sw.bb4 ], [ 16, %sw.bb3 ],
+ [ 9, %sw.bb2 ], [ 4, %sw.bb1 ], [ %param, %entry ]
+ ret i32 %retval.0
+}
Index: llvm/lib/Target/PowerPC/PPCISelLowering.cpp
===================================================================
--- llvm/lib/Target/PowerPC/PPCISelLowering.cpp
+++ llvm/lib/Target/PowerPC/PPCISelLowering.cpp
@@ -2554,7 +2554,9 @@
ConstPoolNode->getTargetFlags() | PPCII::MO_PCREL_FLAG;
GlobalAddressSDNode *GSDN = dyn_cast<GlobalAddressSDNode>(N.getNode());
bool Global = GSDN && GSDN->getTargetFlags() | PPCII::MO_PCREL_FLAG;
- if (ConstPool || Global) {
+ JumpTableSDNode *JT = dyn_cast<JumpTableSDNode>(N.getNode());
+ bool JumpTable = JT && JT->getTargetFlags() | PPCII::MO_PCREL_FLAG;
+ if (ConstPool || Global || JumpTable) {
Base = N;
return true;
}
@@ -2851,6 +2853,15 @@
EVT PtrVT = Op.getValueType();
JumpTableSDNode *JT = cast<JumpTableSDNode>(Op);
+ // isUsingPCRelativeCalls() returns true when PCRelative is enabled
+ if (Subtarget.isUsingPCRelativeCalls()) {
+ SDLoc DL(JT);
+ EVT Ty = getPointerTy(DAG.getDataLayout());
+ SDValue GA =
+ DAG.getTargetJumpTable(JT->getIndex(), Ty, PPCII::MO_PCREL_FLAG);
+ SDValue MatAddr = DAG.getNode(PPCISD::MAT_PCREL_ADDR, DL, Ty, GA);
+ return MatAddr;
+ }
// 64-bit SVR4 ABI and AIX ABI code are always position-independent.
// The actual address of the GlobalValue is stored in the TOC.
if (Subtarget.is64BitELFABI() || Subtarget.isAIXABI()) {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75931.258161.patch
Type: text/x-patch
Size: 3571 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200416/8d398846/attachment.bin>
More information about the llvm-commits
mailing list