[PATCH] D77231: [lld] Support --lto-emit-asm and --plugin-opt=emit-asm
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 16 13:23:34 PDT 2020
MaskRay added a comment.
In D77231#1987231 <https://reviews.llvm.org/D77231#1987231>, @hoyFB wrote:
> Please let me know any more feedbacks.
Mostly good correct. @tejohnson ^^
> I'm planning to land this shortly. Thanks!
This sentence does not look right. There are still a few comments not addressed. One is a critical one: `; REQUIRES: x86`. Without it the test will fail on a built LLVM with the x86 target disabled. Some people maintaining ARM bots will assuredly revert your change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77231/new/
https://reviews.llvm.org/D77231
More information about the llvm-commits
mailing list