[llvm] 8e8c3c3 - [ARM] Mir test for machine sinking multiple def instructions. NFC

[David Green via llvm-commits]

Author: David Green
Date: 2020-04-16T20:58:14+01:00
New Revision: 8e8c3c3408481f5219e9bcf8d06c464ae149c3f7

URL: https://github.com/llvm/llvm-project/commit/8e8c3c3408481f5219e9bcf8d06c464ae149c3f7
DIFF: https://github.com/llvm/llvm-project/commit/8e8c3c3408481f5219e9bcf8d06c464ae149c3f7.diff

LOG: [ARM] Mir test for machine sinking multiple def instructions. NFC

Added: 
    llvm/test/CodeGen/ARM/machine-sink-multidef.mir

Modified: 
    llvm/lib/CodeGen/MachineSink.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/MachineSink.cpp b/llvm/lib/CodeGen/MachineSink.cpp
index 01a7be47b62e..74b71eb7ebdf 100644
--- a/llvm/lib/CodeGen/MachineSink.cpp
+++ b/llvm/lib/CodeGen/MachineSink.cpp
@@ -279,7 +279,7 @@ MachineSinking::AllUsesDominatedByBlock(unsigned Reg,
   //
   // %bb.2:
   //     %p = PHI %y, %bb.0, %def, %bb.1
-  if (llvm::all_of(MRI->use_nodbg_operands(Reg), [&](MachineOperand &MO) {
+  if (all_of(MRI->use_nodbg_operands(Reg), [&](MachineOperand &MO) {
         MachineInstr *UseInst = MO.getParent();
         unsigned OpNo = UseInst->getOperandNo(&MO);
         MachineBasicBlock *UseBlock = UseInst->getParent();

diff  --git a/llvm/test/CodeGen/ARM/machine-sink-multidef.mir b/llvm/test/CodeGen/ARM/machine-sink-multidef.mir
new file mode 100644
index 000000000000..f0de852d319c
--- /dev/null
+++ b/llvm/test/CodeGen/ARM/machine-sink-multidef.mir
@@ -0,0 +1,87 @@
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+# RUN: llc %s -o - -run-pass=machine-sink -mtriple=arm-none-eabi | FileCheck %s
+
+--- |
+  target datalayout = "e-m:e-p:32:32-Fi8-i64:64-v128:64:128-a:0:32-n32-S64"
+  target triple = "arm-none-unknown-eabi"
+
+  %struct.anon = type { i32, i32 }
+
+  @e = external constant [2 x %struct.anon], align 4
+
+  define arm_aapcscc void @g(i32 * noalias %a, i32 *%b, i32 %x) {
+  entry:
+    %c = getelementptr inbounds [2 x %struct.anon], [2 x %struct.anon]* @e, i32 0, i32 %x, i32 0
+    %l1 = load i32, i32* %c, align 4
+    %d = getelementptr inbounds [2 x %struct.anon], [2 x %struct.anon]* @e, i32 0, i32 %x, i32 1
+    %l2 = load i32, i32* %d, align 4
+    br i1 undef, label %land.lhs.true, label %if.end
+
+  land.lhs.true:                                    ; preds = %entry
+    br label %if.end
+
+  if.end:                                           ; preds = %land.lhs.true, %entry
+    %h.0 = phi i32 [ %l1, %entry ], [ 0, %land.lhs.true ]
+    ret void
+  }
+
+...
+---
+name:            g
+tracksRegLiveness: true
+registers:
+  - { id: 0, class: gpr, preferred-register: '' }
+  - { id: 1, class: gpr, preferred-register: '' }
+  - { id: 2, class: gpr, preferred-register: '' }
+  - { id: 6, class: gpr, preferred-register: '' }
+  - { id: 7, class: gpr, preferred-register: '' }
+  - { id: 8, class: gpr, preferred-register: '' }
+  - { id: 9, class: gprnopc, preferred-register: '' }
+liveins:
+  - { reg: '$r0', virtual-reg: '%8' }
+  - { reg: '$r1', virtual-reg: '%9' }
+liveins:         []
+body:             |
+  ; CHECK-LABEL: name: g
+  ; CHECK: bb.0:
+  ; CHECK:   successors: %bb.1(0x40000000), %bb.3(0x40000000)
+  ; CHECK:   liveins: $r0, $r1
+  ; CHECK:   [[COPY:%[0-9]+]]:gpr = COPY $r1
+  ; CHECK:   [[COPY1:%[0-9]+]]:gprnopc = COPY $r0
+  ; CHECK:   [[LDR_PRE_REG:%[0-9]+]]:gpr, [[LDR_PRE_REG1:%[0-9]+]]:gpr = LDR_PRE_REG [[COPY]], killed [[COPY1]], 16387, 14 /* CC::al */, $noreg :: (load 4 from %ir.c)
+  ; CHECK:   [[MOVi:%[0-9]+]]:gpr = MOVi 0, 14 /* CC::al */, $noreg, $noreg
+  ; CHECK:   CMPri [[MOVi]], 0, 14 /* CC::al */, $noreg, implicit-def $cpsr
+  ; CHECK:   Bcc %bb.1, 0 /* CC::eq */, $cpsr
+  ; CHECK: bb.3:
+  ; CHECK:   successors: %bb.2(0x80000000)
+  ; CHECK:   B %bb.2
+  ; CHECK: bb.1:
+  ; CHECK:   successors: %bb.2(0x80000000)
+  ; CHECK: bb.2:
+  ; CHECK:   [[PHI:%[0-9]+]]:gpr = PHI [[LDR_PRE_REG]], %bb.3, [[MOVi]], %bb.1
+  ; CHECK:   CMPri [[MOVi]], 0, 14 /* CC::al */, $noreg, implicit-def $cpsr
+  ; CHECK:   [[LDRi12_:%[0-9]+]]:gpr = LDRi12 killed [[LDR_PRE_REG1]], 4, 14 /* CC::al */, $noreg :: (load 4 from %ir.d)
+  ; CHECK:   MOVPCLR 14 /* CC::al */, $noreg
+  bb.0:
+    liveins: $r0, $r1
+    successors: %bb.1(0x40000000), %bb.2(0x40000000)
+
+    %8:gpr = COPY $r1
+    %9:gprnopc = COPY $r0
+    %0:gpr, %6:gpr = LDR_PRE_REG %8, killed %9, 16387, 14, $noreg :: (load 4 from %ir.c)
+    %7:gpr = MOVi 0, 14, $noreg, $noreg
+    CMPri %7, 0, 14, $noreg, implicit-def $cpsr
+    Bcc %bb.2, 1, $cpsr
+    B %bb.1
+
+  bb.1:
+    successors: %bb.2(0x80000000)
+
+  bb.2:
+
+    %2:gpr = PHI %0, %bb.0, %7, %bb.1
+    CMPri %7, 0, 14, $noreg, implicit-def $cpsr
+    %1:gpr = LDRi12 killed %6, 4, 14, $noreg :: (load 4 from %ir.d)
+    MOVPCLR 14, $noreg
+
+...