[PATCH] D78071: [mlir] [VectorOps] Progressive lowering of vector.broadcast

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache requested changes to this revision.
nicolasvasilache added inline comments.
This revision now requires changes to proceed.


================
Comment at: mlir/lib/Dialect/Vector/VectorTransforms.cpp:1083
+          }
+          auto ipos = rewriter.getI64ArrayAttr(d);
+          result = rewriter.create<vector::InsertOp>(loc, dstVectorType, bcst,
----------------
In the proposed control-flow change, this line and the next would be duplicated.
You can reduce that with another nit: builder that takes an int.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78071/new/

https://reviews.llvm.org/D78071