[PATCH] D78314: [mlir][Pass] Add support for generating minimal crash reproducers

[Jacques Pienaar via Phabricator via llvm-commits]

jpienaar added inline comments.


================
Comment at: mlir/docs/PassManagement.md:1001
+`pass-pipeline-minimal-reproducer` on the command line, that signals that the
+pass manager should attempt to generate a "minimal" reproducer. This will
+attempt to generate a reproducer containing IR right before the pass that fails.
----------------
minimal has to me a size connotation (e.g., "minimum amount of code needed to make the bug appear when executed."), and here it is more about scope than size (e.g., you only need to run one pass, but your reproducer may be huge). Would "local" or "pass-pipeline-dump-before-first-fail" work? Alternatively, where do you see someone not wanting this behavior?


================
Comment at: mlir/docs/PassManagement.md:1004
+This is useful for situations where the crash is known to be within a specific
+pass, or when the original input relies on components(like dialects or passes)
+that may not always be available.
----------------
Missing space before (


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78314/new/

https://reviews.llvm.org/D78314