[PATCH] D78321: [MLIR][cmake] Use DEPENDS instead of add_dependencies()

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer created this revision.
Herald added subscribers: llvm-commits, frgossen, grosul1, Joonsoo, liufengdb, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar, rriddle, mehdi_amini, mgorny.
Herald added a project: LLVM.

add_llvm_library() sometimes needs access to the dependencies in order to
generate new targets.  Using DEPENDS allows this.

Depends on D78320 <https://reviews.llvm.org/D78320>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D78321

Files:
  mlir/lib/Interfaces/CMakeLists.txt


Index: mlir/lib/Interfaces/CMakeLists.txt
===================================================================
--- mlir/lib/Interfaces/CMakeLists.txt
+++ mlir/lib/Interfaces/CMakeLists.txt
@@ -12,8 +12,8 @@
 
   ADDITIONAL_HEADER_DIRS
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces
-  )
-add_dependencies(MLIRCallInterfaces
+
+  DEPENDS
   MLIRCallInterfacesIncGen
   )
 target_link_libraries(MLIRCallInterfaces
@@ -26,8 +26,8 @@
 
   ADDITIONAL_HEADER_DIRS
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces
-  )
-add_dependencies(MLIRControlFlowInterfaces
+
+  DEPENDS
   MLIRControlFlowInterfacesIncGen
   )
 target_link_libraries(MLIRControlFlowInterfaces
@@ -40,8 +40,8 @@
 
   ADDITIONAL_HEADER_DIRS
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces
-  )
-add_dependencies(MLIRDerivedAttributeOpInterface
+
+  DEPENDS
   MLIRDerivedAttributeOpInterfaceIncGen
   )
 target_link_libraries(MLIRDerivedAttributeOpInterface
@@ -54,8 +54,8 @@
 
   ADDITIONAL_HEADER_DIRS
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces
-  )
-add_dependencies(MLIRInferTypeOpInterface
+
+  DEPENDS
   MLIRInferTypeOpInterfaceIncGen
   )
 target_link_libraries(MLIRInferTypeOpInterface
@@ -68,8 +68,8 @@
 
   ADDITIONAL_HEADER_DIRS
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces
-  )
-add_dependencies(MLIRLoopLikeInterface
+
+  DEPENDS
   MLIRLoopLikeInterfaceIncGen
   )
 target_link_libraries(MLIRLoopLikeInterface
@@ -82,8 +82,8 @@
 
   ADDITIONAL_HEADER_DIRS
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces
-  )
-add_dependencies(MLIRSideEffects
+
+  DEPENDS
   MLIRSideEffectOpInterfacesIncGen
   )
 target_link_libraries(MLIRSideEffects


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78321.258130.patch
Type: text/x-patch
Size: 1597 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200416/06d63803/attachment-0001.bin>