[PATCH] D78306: [flang] Use LLVM's flags

Isuru Fernando via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 16 11:41:41 PDT 2020


isuruf marked an inline comment as done.
isuruf added inline comments.


================
Comment at: flang/unittests/Evaluate/CMakeLists.txt:96
 )
+llvm_update_compile_flags(real-test)
 
----------------
ChinouneMehdi wrote:
> `add_flang_executable` should be sufficient.
That doesn't work. `add_flang_executable` is meant for executables to be installed. Not for test executables.

Fails with a bunch of
```
CMake Error at /home/isuru/projects/llvm-project/llvm/cmake/modules/LLVMProcessSources.cmake:112 (message):
  Found unknown source file uint128.cpp

  Please update
  /home/isuru/projects/llvm-project/flang/unittests/Evaluate/CMakeLists.txt

Call Stack (most recent call first):
  /home/isuru/projects/llvm-project/llvm/cmake/modules/LLVMProcessSources.cmake:62 (llvm_check_source_file_list)
  /home/isuru/projects/llvm-project/llvm/cmake/modules/AddLLVM.cmake:766 (llvm_process_sources)
  /home/isuru/projects/llvm-project/flang/cmake/modules/AddFlang.cmake:101 (add_llvm_executable)
  /home/isuru/projects/llvm-project/flang/unittests/Evaluate/CMakeLists.txt:93 (add_flang_executable)
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78306/new/

https://reviews.llvm.org/D78306





More information about the llvm-commits mailing list