[PATCH] D78306: [flang] Use LLVM's flags

[مهدي شينون (Mehdi Chinoune) via Phabricator via llvm-commits]

ChinouneMehdi added inline comments.


================
Comment at: flang/CMakeLists.txt:62
   endif()
+  option(LLVM_ENABLE_WARNINGS "Enable compiler warnings." ON)
+  option(LLVM_ENABLE_WERROR "Fail and stop if a warning is triggered." ON)
----------------
`LLVM_ENABLE_WARNINGS` is enabled by default.


================
Comment at: flang/CMakeLists.txt:63
+  option(LLVM_ENABLE_WARNINGS "Enable compiler warnings." ON)
+  option(LLVM_ENABLE_WERROR "Fail and stop if a warning is triggered." ON)
 
----------------
Are you sure this could be enabled with MSVC.
Even LLVM can't be built with it.


================
Comment at: flang/unittests/Evaluate/CMakeLists.txt:96
 )
+llvm_update_compile_flags(real-test)
 
----------------
`add_flang_executable` should be sufficient.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78306/new/

https://reviews.llvm.org/D78306