[PATCH] D78087: [MachineSink] Fix for breaking phi edges with instructions with multiple defs

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineSink.cpp:282
+  //     %p = PHI %y, %bb.0, %def, %bb.1
+  if (llvm::all_of(MRI->use_nodbg_operands(Reg), [&](MachineOperand &MO) {
+        MachineInstr *UseInst = MO.getParent();
----------------
nit: llvm:: not needed?


================
Comment at: llvm/test/CodeGen/ARM/machine-sink-multidef.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=arm-none-eabi | FileCheck %s
----------------
nit: Would be great to have a MIR test for this :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78087/new/

https://reviews.llvm.org/D78087