[PATCH] D78190: Add Bfloat IR type

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 16 08:54:45 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/test/Assembler/bfloat-constprop.ll:1
+; RUN: opt < %s -O3 -S | FileCheck %s
+; RUN: verify-uselistorder %s
----------------
This test is doing way too much. You can reduce the to just ret fadd K0, K1


================
Comment at: llvm/test/Assembler/bfloat-conv.ll:1
+; RUN: opt < %s -O3 -S | FileCheck %s
+; RUN: verify-uselistorder %s
----------------
Ditto


================
Comment at: llvm/test/Assembler/bfloat.ll:6
+; CHECK: define bfloat @check_bfloat
+define bfloat @check_bfloat(bfloat %A) {
+; CHECK: ret bfloat %A
----------------
Ditto, all of these assembler tests can be in one file


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78190/new/

https://reviews.llvm.org/D78190





More information about the llvm-commits mailing list