[PATCH] D78202: [FileCheck] - Refactor the code related to string arrays. NFCI.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/utils/FileCheck/FileCheck.cpp:539
+  // is probably a bit subtle. So we copy strings instead.
+  BumpPtrAllocator StrAlloc;
+  for (StringRef Prefix : CheckPrefixes)
----------------
`--check-prefix`, `--implicit-check-not` and `-D` are by no means performance/memory usage critical... Using a `BumpPtrAllocator` does not seem to improve the code ?

Can other cleanups in this patch be retained if you don't change the 3 variables to `std::vector<StringRef>`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78202/new/

https://reviews.llvm.org/D78202