[PATCH] D78005: [yaml2obj] - Reimplement how tool calculates file and memory sizes of segments.

[George Rimar via Phabricator via llvm-commits]

grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: llvm/test/Object/invalid.test:488
   Machine: EM_X86_64
-Sections:
-  - Name: .dynamic
----------------
grimar wrote:
> jhenderson wrote:
> > Why has this test changed?
> Because my code uses the `Offset` which is misused here. We use it here like it is `ShOffset`, i.e. to override the value,
> but it is not what `Offset` field should do. I think it should be used to set value that is <= the offset of the first section in the segment.
> 
> We might probably want to add `ShOffset`.
I've prepared the patch for this: D78304


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78005/new/

https://reviews.llvm.org/D78005