[PATCH] D78045: [XCOFF][AIX] Fix getSymbol to return the correct qualname when necessary
Digger via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 16 08:22:00 PDT 2020
DiggerLin added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1596
MCSymbolXCOFF *GVSym = cast<MCSymbolXCOFF>(getSymbol(GV));
GVSym->setStorageClass(
TargetLoweringObjectFileXCOFF::getStorageClassForGlobal(GV));
----------------
DiggerLin wrote:
> since we get the qualname symbol, I do not think we need to set
> GVSym->setStorageClass (....) here.
sorry, please discard the comment, maybe label here, it still need to set the StorageClass() here
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78045/new/
https://reviews.llvm.org/D78045
More information about the llvm-commits
mailing list