[PATCH] D78215: [flang] Use the Flang cmake-functions to add targets.

Thu Apr 16 06:10:23 PDT 2020

DavidTruby marked an inline comment as done.
DavidTruby added inline comments.

================
Comment at: flang/lib/Evaluate/CMakeLists.txt:35
   FortranDecimal
-  FortranSemantics
   FortranParser
----------------
DavidTruby wrote:
> tskeith wrote:
> > ChinouneMehdi wrote:
> > > tskeith wrote:
> > > > This dependency was added here: https://reviews.llvm.org/rGa1726e65bc1fdbd2800839e48e68cb4a68cc7092
> > > > Have you verified that this change doesn't re-introduce the problem that that one was fixing?
> > > I have verified with four configurations ( gcc-8+gold, gcc-9+gold, clang-8+lld and clang-9+lld) on Ubuntu 18.04 x86_64.
> > > I can't be sure because I don't know about his build configuration.
> > That sounds good to me.
> I'm not sure why it doesn't reintroduce the linker issue from there, but it doesn't seem to. I'll just double check on the configuration I used there.
Yep, no issue with this patch. Not sure why the issue has gone away, but it should make fixing shared library builds easier!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78215/new/

https://reviews.llvm.org/D78215