[PATCH] D78088: [MIR] Add comments to INLINEASM immediate flag MachineOperands
Konstantin Schwarz via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 16 05:03:25 PDT 2020
kschwarz marked an inline comment as done.
kschwarz added inline comments.
================
Comment at: llvm/lib/CodeGen/TargetInstrInfo.cpp:1326
+// Returns a MIRPrinter comment for this machine operand.
+std::string TargetInstrInfo::createMIROperandComment(
+ const MachineInstr &MI, const MachineOperand &Op, unsigned OpIdx,
----------------
arsenm wrote:
> Should this write to a raw_ostream rather than returning a string?
I'm not sure why it originally returned a string, but the function already existed before this patch
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78088/new/
https://reviews.llvm.org/D78088
More information about the llvm-commits
mailing list