[PATCH] D66443: [LifetimeAnalysis] Add [[gsl::Pointer]] to llvm::StringRef

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

In D66443#1986255 <https://reviews.llvm.org/D66443#1986255>, @labath wrote:

> +1
>
> builds with compilers which don't implement this attribute are basically useless. This should either be predicated on the compiler supporting this attribute, or -W(unknown-)attributes should be disabled in cmake.


Disabling -W(unknown-)attributes will just allow this kind of issue to become more rampant, this needs adding to llvm\support\compiler.h similar to how we manage LLVM_FALLTHROUGH


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66443/new/

https://reviews.llvm.org/D66443