[PATCH] D78264: [AArch64CondBrTuning] Ignore debug insts when scanning for NZCV clobbers [9/10]
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 16 03:23:26 PDT 2020
fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.
LGTM, thanks
================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:3179
+ const TargetRegisterInfo *TRI) {
+ for (const MachineInstr &I : instructionsWithoutDebug(
+ std::next(DefMI.getIterator()), UseMI.getIterator()))
----------------
nit: could be something like
```
return any_of(instructionsWithoutDebug( std::next(DefMI.getIterator()), UseMI.getIterator()), [TRI](MachineInstr &I) {
return I.modifiesRegister(AArch64::NZCV, TRI) || I.readsRegister(AArch64::NZCV, TRI);
});
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78264/new/
https://reviews.llvm.org/D78264
More information about the llvm-commits
mailing list