[PATCH] D78276: [X86][MC][NFC] Reduce the parameters of functions in X86MCCodeEmitter(Part II)
Kan Shengchen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 16 00:47:52 PDT 2020
skan marked an inline comment as done.
skan added inline comments.
================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86MCCodeEmitter.cpp:1279
+ emitByte(0x40 | REX, CurByte, OS);
+
----------------
craig.topper wrote:
> Don't we need to check that REX is non-zero before emitting the byte? Am I missing something?
you are right. I missed this
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78276/new/
https://reviews.llvm.org/D78276
More information about the llvm-commits
mailing list