[PATCH] D78276: [X86][MC][NFC] Reduce the parameters of functions in X86MCCodeEmitter(Part II)

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 16 00:10:33 PDT 2020


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86MCCodeEmitter.cpp:1396
 
-  bool Rex = false;
-  emitPrefixImpl(CurOp, CurByte, Rex, MI, STI, OS);
+  bool HasREX = static_cast<bool>(emitPrefixImpl(CurOp, CurByte, MI, STI, OS));
 
----------------
Why not return it as a bool from emitREXPrefix?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78276/new/

https://reviews.llvm.org/D78276





More information about the llvm-commits mailing list