[PATCH] D78256: [llvm][NFC][CallSite] Removed CallSite from some implementation details.

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/FunctionComparator.cpp:179
 
   assert(LCS && RCS && "Must be calls or invokes!");
+  assert(isa<CallInst>(LCS) == isa<CallInst>(RCS) &&
----------------
craig.topper wrote:
> If we use cast instead of dyn_cast we can drop this assert.
Thanks, in fact, the API should be refactored afterwards. Left a fixme. Also the assert comment may have been incorrect, come to think of it, the function seems to work fine for CallBrInst, too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78256/new/

https://reviews.llvm.org/D78256