[PATCH] D78197: [mlir][spirv] Lower memref with dynamic dimensions to runtime arrays

[Mahesh Ravishankar via Phabricator via llvm-commits]

mravishankar accepted this revision.
mravishankar added a comment.
This revision is now accepted and ready to land.

This is great! Thanks Lei, The type conversion looks good, but its hard to see how this works without seeing how it works in practice without seeing it work with loads/stores.



================
Comment at: mlir/lib/Dialect/SPIRV/SPIRVLowering.cpp:334
                                         MemRefType type) {
-  // TODO(ravishankarm) : Handle dynamic shapes.
-  if (!type.hasStaticShape()) {
+  auto storageClass =
+      SPIRVTypeConverter::getStorageClassForMemorySpace(type.getMemorySpace());
----------------
Nit: Good to avoid using auto here cause the type of the result is not obvious.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78197/new/

https://reviews.llvm.org/D78197