[PATCH] D78261: [globalisel] Allow backends to report an issue without triggering fallback. NFC

[Daniel Sanders via Phabricator via llvm-commits]

dsanders marked 2 inline comments as done.
dsanders added a comment.

Thanks



================
Comment at: llvm/lib/CodeGen/GlobalISel/Utils.cpp:201
 
-void llvm::reportGISelFailure(MachineFunction &MF, const TargetPassConfig &TPC,
-                              MachineOptimizationRemarkEmitter &MORE,
-                              MachineOptimizationRemarkMissed &R) {
-  MF.getProperties().set(MachineFunctionProperties::Property::FailedISel);
-
+static void reportGISelDiagnostic(bool AllowFatal, MachineFunction &MF,
+                                  const TargetPassConfig &TPC,
----------------
qcolombet wrote:
> Instead of `AllowFatal` could we have a severity enum?
> For now, maybe just warning and failure, where failure would be equivalent to AllowFatal == true?
Sure, I'll re-use `DiagnosticSeverity`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78261/new/

https://reviews.llvm.org/D78261