[PATCH] D78156: [AArch64ConditionalCompares] Ignore debug insts in findConvertibleCompare [7/10]

[Vedant Kumar via Phabricator via llvm-commits]

vsk updated this revision to Diff 257930.
vsk retitled this revision from "[AArch64ConditionalCompares] Ignore debug insts in findConvertibleCompare" to "[AArch64ConditionalCompares] Ignore debug insts in findConvertibleCompare [7/10]".
vsk added a comment.

retitle, use prev_nodbg helper


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78156/new/

https://reviews.llvm.org/D78156

Files:
  llvm/lib/Target/AArch64/AArch64ConditionalCompares.cpp
  llvm/test/CodeGen/AArch64/arm64-ccmp.ll


Index: llvm/test/CodeGen/AArch64/arm64-ccmp.ll
===================================================================
--- llvm/test/CodeGen/AArch64/arm64-ccmp.ll
+++ llvm/test/CodeGen/AArch64/arm64-ccmp.ll
@@ -1,4 +1,4 @@
-; RUN: llc < %s -mcpu=cyclone -verify-machineinstrs -aarch64-enable-ccmp -aarch64-stress-ccmp | FileCheck %s
+; RUN: llc < %s -debugify-and-strip-all-safe -mcpu=cyclone -verify-machineinstrs -aarch64-enable-ccmp -aarch64-stress-ccmp | FileCheck %s
 target triple = "arm64-apple-ios"
 
 ; CHECK: single_same
Index: llvm/lib/Target/AArch64/AArch64ConditionalCompares.cpp
===================================================================
--- llvm/lib/Target/AArch64/AArch64ConditionalCompares.cpp
+++ llvm/lib/Target/AArch64/AArch64ConditionalCompares.cpp
@@ -317,7 +317,7 @@
 
   // Now find the instruction controlling the terminator.
   for (MachineBasicBlock::iterator B = MBB->begin(); I != B;) {
-    --I;
+    I = prev_nodbg(I, MBB->begin());
     assert(!I->isTerminator() && "Spurious terminator");
     switch (I->getOpcode()) {
     // cmp is an alias for subs with a dead destination register.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78156.257930.patch
Type: text/x-patch
Size: 1125 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200416/19253fd5/attachment.bin>