[PATCH] D78254: [GIsel][CombinerHelper] Fix missed ElideBrByInvertingCond combine [4/10]
Vedant Kumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 15 18:46:44 PDT 2020
vsk planned changes to this revision.
vsk marked an inline comment as done.
vsk added inline comments.
================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:645
MachineInstr *AddrDef = getOpcodeDef(TargetOpcode::G_PTR_ADD, Addr, MRI);
- if (!AddrDef || MRI.hasOneUse(Addr))
+ if (!AddrDef || MRI.hasOneNonDBGUse(Addr))
return false;
----------------
aemerson wrote:
> This looks like an unrelated fix?
Hm, you're right, I don't think it's exercised by the test change. I'll try to find some other way to exercise this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78254/new/
https://reviews.llvm.org/D78254
More information about the llvm-commits
mailing list